Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Import Documents sanitizes pdfs #435

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

ajdapretnar
Copy link
Collaborator

Issue

Fixes #426.

Description of changes

Remove NULL bytes from pdfs.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

Codecov Report

Merging #435 into master will increase coverage by 0.31%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
+ Coverage   85.65%   85.96%   +0.31%     
==========================================
  Files          34       34              
  Lines        1931     1931              
  Branches      331      331              
==========================================
+ Hits         1654     1660       +6     
+ Misses        236      230       -6     
  Partials       41       41

@ajdapretnar ajdapretnar changed the title Import Documents sanitizes pdfs [WIP] Import Documents sanitizes pdfs Jun 7, 2019
@ajdapretnar
Copy link
Collaborator Author

@robertcv Once you check this, I can add a test. If you think of a better solution, let me know.

@ajdapretnar ajdapretnar force-pushed the import-documents-fix branch from 1cb10e2 to cba4552 Compare June 14, 2019 08:04
@robertcv robertcv merged commit a8ca79e into biolab:master Jun 14, 2019
@lawrencerowland
Copy link

late to this, but brilliant, many thanks

@ajdapretnar ajdapretnar deleted the import-documents-fix branch January 21, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving a tab file after using 'import documents widget'
4 participants